Repository navigation
feat(task-store): add JPA ownership scopes for task listings - #1259
Merged
Merged
Conversation
Add optional backend-neutral authorization capabilities and an explicitly selected JPA ownership provider. Apply matching authorization scopes to count and page queries while preserving deny-by-default behavior and bounded fallback checks with opaque-token recovery. Persist exact UTF-8 subject identities as binary ownership keys and isolate first-writer-wins insertion and confirmation transactions. Cover identity equality and repeatable-read ownership races on PostgreSQL and MySQL, and document schema migrations, provider selection, and cloud deployment. Signed-off-by: Kabir Khan <kkhan@redhat.com>
kabir
force-pushed
the
jpa-task-ownership
branch
from
November 2, 2026 16:02
af92bae to
125fb62
Compare
jmesnil
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authorized JPA task listings currently scan candidates and check them individually. This change adds optional provider capabilities so supported policies can filter both the database count and page queries directly, reducing scan and deserialization costs.
An explicitly selected
JpaTaskAuthorizationProviderpersists first-owner task associations and supplies ownership scopes to the JPA store. Existing providers retain the bounded fallback. The change also improves fallback handling of opaque continuation tokens and documents provider selection, schema migration, identity semantics, and cloud deployment configuration.Coverage includes capability discovery, query filtering, fallback pagination, CDI selection, exact subject identities, and ownership races on PostgreSQL and MySQL. CI explicitly enables database tests on Linux.
Validation:
mvn -B -pl server-common,extras/task-store-database-jpa -am package -DskipDockerTests=falsepassed (1,931 tests, zero failures or errors, six skipped), including the PostgreSQL and MySQL ownership tests.