Repository navigation
Conversation
Add a dedicated JDK 25 workflow and contributor commands. Exclude build outputs, generated gRPC sources, and released documentation snapshots. Disable type shortening that drops nullability annotations and Markdown reflow that corrupts lists. This fixes a2aproject#139
Apply the configured Java and POM formatting throughout the repository. This fixes a2aproject#139
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotless was configured but skipped by default, so CI did not report formatting violations. Add a dedicated JDK 25 formatting workflow that explicitly enables
spotless:checkon pushes and pull requests, including documentation-only changes.The infrastructure commit documents the formatter commands and excludes generated gRPC sources, build outputs, and frozen documentation snapshots. It also removes two unsafe transformations discovered during validation: fully qualified type shortening dropped
@Nullableannotations, and Flexmark reflow collapsed Markdown lists into paragraphs. Markdown retains newline checks.The second commit applies the configured Java and POM formatting. Generated sources and released documentation are unchanged. Ordinary builds retain their default skip setting so Java 17 builds do not invoke the newer formatter.
Validation on JDK 25:
mvn -B -N -Dskip.spotless=false spotless:checkpassed.mvn -B package -DskipDockerTests=true -faepassed across all 83 modules; 3,712 tests reported, zero failures/errors, 137 skipped.git diff --checkpassed.This fixes #139