Repository navigation
hack/run-e2e.sh accepts the target path after go test flags - #2226
Open
Eric Curtin (ericcurtin) wants to merge 5 commits into
Open
Eric Curtin (ericcurtin) wants to merge 5 commits into
Eric Curtin (ericcurtin) wants to merge 5 commits into
Conversation
Contributor
Author
|
Tim Hockin (@thockin) Steven Shriver (@stshrive) PTAL when you get a chance. Thank you! |
2 tasks done
Max Smythe (maxsmythe)
added
kind/bug
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for submitting a fix.
Do we really need the go regression test for the bash parser that wraps go? That feels like agent excess and it represents the bulk of the difference.
Contributor
Author
|
Benjamin Elder (@BenTheElder) Dropped the Go test, only the script change is left. PTAL. |
Steven Shriver (stshrive)
approved these changes
Oct 7, 2026
Contributor
Author
|
Michelle Au (@msau42) Lior Lieberman (@LiorLieberman) PTAL when you get a chance, it already has one approval. Thank you! |
# Conflicts: # hack/run-e2e.sh
Contributor
Author
|
Merged main and resolved the conflicts. PTAL. |
Contributor
Author
|
Benjamin Elder (@BenTheElder) Haven Xia (@HavenXia) Module-qualified paths are accepted now. PTAL when you get a chance. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2217
The target path can now follow go test flags, so both orders in the issue run the same command.