Repository navigation
benchmarking: remove default ATE_ENV_IMAGE and stop deploying ate-env template by default - #3366
Merged
Max Smythe (maxsmythe) merged 1 commit intoOct 28, 2026
Conversation
Sairaj Pokale (sairajp-rewind)
marked this pull request as ready for review
October 28, 2026 20:19
Sairaj Pokale (sairajp-rewind)
force-pushed
the
ate-env-remove-default-image
branch
from
October 28, 2026 20:21
1bae83f to
e9ffb81
Compare
Sairaj Pokale (sairajp-rewind)
requested a review
from Max Smythe (maxsmythe)
October 28, 2026 20:44
Anna Pendleton (annapendleton)
approved these changes
Oct 28, 2026
Collaborator
|
Let me know if any requests come up for a publicly hosted image on the benchmarking workstream, we can look at alternative options for this when the need arises :) |
… by default Signed-off-by: Sairaj Pokale <sairajpokale@google.com>
Sairaj Pokale (sairajp-rewind)
force-pushed
the
ate-env-remove-default-image
branch
from
October 28, 2026 21:24
e9ffb81 to
37b3c3d
Compare
Collaborator
Author
Thank you! |
Max Smythe (maxsmythe)
approved these changes
Oct 28, 2026
Max Smythe (maxsmythe)
left a comment
Max Smythe (maxsmythe)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, this is a benchmarking-only change, so merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the default
ATE_ENV_IMAGEdigest and excludeate-envfrom the defaultWORKLOAD_TEMPLATESlist.deploy.shnow deploysate-envonly whenATE_ENV_IMAGEis set (orWORKLOAD_TEMPLATESincludesate-env), and always includes it on--deleteso teardown cleans up the template.