Repository navigation
Fix XComArg.map() failing when the upstream XCom is a dict - #75022
Open
justinpakzad wants to merge 1 commit into
Open
justinpakzad wants to merge 1 commit into
justinpakzad wants to merge 1 commit into
Conversation
justinpakzad
force-pushed
the
fix/xcom-map-over-dict
branch
from
October 19, 2026 22:35
8fc5f56 to
59d31e4
Compare
justinpakzad
marked this pull request as ready for review
October 19, 2026 22:35
justinpakzad
force-pushed
the
fix/xcom-map-over-dict
branch
from
October 29, 2026 21:26
59d31e4 to
65963ed
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, tasks that use
.map()over a dict input fail because_MapResult.__getitem__uses the index as a dict key (dict[0]), which raisesKeyError.MapXComArg.resolve()says "XCom map expects sequence or dict", so dictionaries appear to be a valid type here. This PR updates__getitem__to select the dict entry by position, so each callable gets a key/value pair, matching howexpand()handles a dict. Additional test cases were added to cover the new behavior.Repro Dag
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.