Repository navigation
Pin the real selective-checks auto-approve test to main - #75682
Merged
Merged
Conversation
The test decides approval for a PR targeting main, but built SelectiveChecks with the checkout's default branch. On a release branch that skips provider tests, so the large provider change was estimated cheap and approved. Generated-by: Claude Opus 5
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
vatsrahul1001
as code owners
October 26, 2026 17:21
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-4-test
shahar1
approved these changes
Oct 26, 2026
shahar1
approved these changes
Oct 26, 2026
Contributor
Backport failed to create: v3-4-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 36038d7 v3-4-testThis should apply the commit to the v3-4-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_decide_approval_with_real_selective_checksdecides approval for a PR targetingmain, but builtSelectiveCheckswith the checkout's default branch. It passes onmaintoday, but on a release branch selective checks skip provider tests, so the large provider change is estimated cheap and approved, failing the test. That already happened when backporting the auto-approval changes tov3-4-test(#75680). The test now pinsdefault_branch="main", asbuild_selective_checksalready does in production.Checks run locally:
dev/breeze/tests/test_workflow_run_approval.py(117 passed).Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5 following the guidelines
🤖 Generated with Claude Code