Repository navigation
[v3-4-test] Refuse to publish constraints when the branch moved during generation (#75989) - #75990
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
1 task done
vatsrahul1001
marked this pull request as ready for review
October 29, 2026 18:46
vatsrahul1001
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
October 29, 2026 18:46
…g generation (#75989) A regular constraints refresh resolves its pins against the constraints branch as it is when the run starts, then commits them on top of the branch as it is when the run ends. When Release constraints commits a release candidate's pins in between, the refresh overwrote them with pins resolved against the older baseline, and the push still succeeded because it was an ordinary fast-forward. The two workflows run in different concurrency groups, so nothing serialised them. The publish now fails instead and asks for a re-run, which then starts from the candidate's constraints. (cherry picked from commit 92bbf67) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Generated-by: Claude Opus 5
vatsrahul1001
force-pushed
the
backport-92bbf67-v3-4-test
branch
from
October 29, 2026 19:33
6e37791 to
5c549dd
Compare
Contributor
Author
|
The re-run of the jobs stopped by EC2 Spot interruptions finished: attempt 2 passed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regular constraints refresh resolves its pins against the constraints
branch as it is when the run starts, then commits them on top of the
branch as it is when the run ends. When Release constraints commits a
release candidate's pins in between, the refresh overwrote them with
pins resolved against the older baseline, and the push still succeeded
because it was an ordinary fast-forward.
The two workflows run in different concurrency groups, so nothing
serialised them. The publish now fails instead and asks for a re-run,
which then starts from the candidate's constraints.
(cherry picked from commit 92bbf67)
Co-authored-by: Jarek Potiuk jarek@potiuk.com
Generated-by: Claude Opus 5