Repository navigation
[v3-4-test] UI: Stop Recent Configurations flashing on the trigger form (#75991) - #75994
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…rm (#75991) * UI: Stop Recent Configurations flashing on the trigger form The section decided to hide itself only once its runs had arrived, so every time the trigger form opened it first drew an empty, disabled select and then either filled it or removed it. The query does not start until the modal opens, which reports as pending rather than loading, so neither flag on its own tells you the runs are in hand. Co-Authored-By: Claude <noreply@anthropic.com> * UI: Lay out Recent Configurations like the rest of the trigger form Every other row in the form names itself in a column down the left and puts its control to the right. This one announced itself in small type above a control that ran the full width, so the eye had to change track in the middle of the form. Co-Authored-By: Claude <noreply@anthropic.com> * UI: Offer recent configurations when they come from cache Runs stay fresh for five minutes, so reopening the trigger form inside that window serves them from cache without fetching. Asking the query whether it had fetched since mounting read that as "not ready" and hid configurations that were already in hand. Nothing needs asking. The options are built from the runs alone, so they are empty both before the runs arrive and when none of them carried a config, and in either case there is nothing to show. Co-Authored-By: Claude <noreply@anthropic.com> --------- (cherry picked from commit 212fe09) Co-authored-by: Brent Bovenzi <brent@astronomer.io> Co-authored-by: Claude <noreply@anthropic.com>
1 task
vatsrahul1001
marked this pull request as ready for review
October 30, 2026 06:46
vatsrahul1001
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 30, 2026 06:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The section decided to hide itself only once its runs had arrived, so every
time the trigger form opened it first drew an empty, disabled select and then
either filled it or removed it. The query does not start until the modal
opens, which reports as pending rather than loading, so neither flag on its
own tells you the runs are in hand.
Co-Authored-By: Claude noreply@anthropic.com
Every other row in the form names itself in a column down the left and puts
its control to the right. This one announced itself in small type above a
control that ran the full width, so the eye had to change track in the middle
of the form.
Co-Authored-By: Claude noreply@anthropic.com
Runs stay fresh for five minutes, so reopening the trigger form inside that
window serves them from cache without fetching. Asking the query whether it
had fetched since mounting read that as "not ready" and hid configurations
that were already in hand.
Nothing needs asking. The options are built from the runs alone, so they are
empty both before the runs arrive and when none of them carried a config, and
in either case there is nothing to show.
Co-Authored-By: Claude noreply@anthropic.com
(cherry picked from commit 212fe09)
Co-authored-by: Brent Bovenzi brent@astronomer.io
Co-authored-by: Claude noreply@anthropic.com