Skip to content

fix: infer domain patterns only from required matcher conditions - #577

Open
EmryZhang wants to merge 1 commit into
masterfrom
prep/node-5.52.0-domain-inference-20261107
Open

EmryZhang wants to merge 1 commit into
masterfrom
prep/node-5.52.0-domain-inference-20261107

Conversation

@EmryZhang

Copy link
Copy Markdown

Quoted matcher text, optional keyMatch branches and resource matching can incorrectly enable domain-pattern role matching. Infer patterns only from positive required conditions bound to the specific role function and its domain argument. Preserve explicit domain matching and normal pattern-domain models.

Eleven regressions cover domain isolation, whitespace, optional and quoted conditions, resource fields, role-function scoping and explicit matching. Lint, 251 tests with no skips and CJS/ESM builds pass; the packed combined candidate passes both module entry points on Node 20 and 22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant