Skip to content

build: retain source license headers in compiled npm outputs - #581

Open
EmryZhang wants to merge 1 commit into
prep/node-5.52.0-headers-20261107from
prep/node-5.52.0-output-licenses-20261107
Open

EmryZhang wants to merge 1 commit into
prep/node-5.52.0-headers-20261107from
prep/node-5.52.0-output-licenses-20261107

Conversation

@EmryZhang

Copy link
Copy Markdown

The ESM bundle and several declaration outputs omit source license headers. Add a post-build pass that preserves the corresponding source header in CJS JS/declarations and includes both the ASF header and node-ip MIT terms in the ESM bundle.

Validation: lint, 240 tests with no skips, both builds, every generated JS/declaration header and byte-stable repeat processing. The combined candidate passes 251 tests on each of Node 20 and 22 and installed CJS/ESM/TypeScript consumers.

Depends on #579; this PR targets its branch so the diff stays focused. Merge it after that prerequisite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant