[LucaCappelletti94]

PRAGMA values such as journal_mode = WAL, synchronous = NORMAL, cache_size = -2000 and optimize = 0x10002 were rejected. The earlier boolean handling also kept its own keyword list plus a value-type allowlist, and that duplicated allowlist is what rejected PRAGMA case_sensitive_like = true in the first place.

parse_pragma_value now follows SQLite's own definition of a pragma value, signed-number | name | signed-literal, and stores the result as an Expr. A bare name like WAL is kept as an identifier, so the parser no longer decides which value a given pragma accepts and leaves that to execution the way SQLite does. parse_pragma builds the statement in a single place.

This changes Statement::Pragma.value from Option<ValueWithSpan> to Option<Expr>.

[iffyio]

I think we could simplify the logic to have it accept whatever parse_value returns. and keep the sqlite semantics for validation upstream? that would have avoided this bug in the initial version

[LucaCappelletti94]

I checked SQLite docs hoping for a limited set of allowed values, it states there is explicitly no such set, and I therefore switched to Expr

[iffyio]

hmm can this be replaced by a call to parse_expr()?

[LucaCappelletti94]

In terms of accepting things, yes it would work, but parse_expr() would over-extend the grammar accepting arbitrary expressions like PRAGMA p = 1 + 2, foo(bar), a AND b or (SELECT 1).

SQLite defines a pragma value as signed-number | name | signed-literal, so parse_pragma_value mirrors that production exactly while still leaving the per-pragma value validation to execution.

I understand I tend to lean much more strongly on the strict parser approach, but here I really believe allowing any expr would be excessively loose.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.53%. Comparing base (b22bf61) to head (ef53be5).

Files with missing lines	Patch %	Lines
src/parser/mod.rs	92.30%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2469      +/-   ##
==========================================
+ Coverage   82.52%   82.53%   +0.01%     
==========================================
  Files          42       42              
  Lines       35533    35537       +4     
  Branches    35533    35537       +4     
==========================================
+ Hits        29323    29331       +8     
+ Misses       2675     2674       -1     
+ Partials     3535     3532       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[s5dsn-eqee]

might be smt like this?

// A bare word that is not a literal (`WAL`, `NORMAL`) is a pragma name.
          if let Token::Word(_) = self.peek_token_ref().token {
              if let Some(value) = self.maybe_parse(|parser| parser.parse_value())? {
                  return Ok(Expr::Value(value));
              }
              return Ok(Expr::Identifier(self.parse_identifier()?));
          }
          Ok(Expr::Value(self.parse_value()?))

Current approach falls back to parse_identifier on any error, so real parse_value errors are hidden.