Repository navigation
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a Jest unit test covering the vertical-orient handle-label separation on
visualMap[type='continuous']withcalculable: true— the case reported in #21766 and discussed there as missing coverage ("The existing overlap cases in test/visualMap-continuous.html are horizontal only").The push-apart behavior itself was implemented in #21586 and refined in 06cd2ea (post-6.1.0, currently only covered by horizontal visual cases). This PR locks it in with logic-level assertions that CI runs on every change.
What the test does
test/ut/spec/component/visualMap/continuousLabelOverlap.test.tsrenders a vertical calculable continuous visualMap over a heatmap with three handle ranges:[50, 50]— both handles at the same position (the exact reported case)[49, 51]— handles one unit apart[0, 100]— handles at opposite ends (control case: separation logic must not misfire)For each range it asserts:
_shapes.handleLabelsfrom the ContinuousView).The test reaches into the view via
ecIns._componentsMap[vmModel.__viewId]._shapes.handleLabels, following the same pattern other UTs use for private view state.How tested
npx jest --config test/ut/jest.config.cjs test/ut/spec/component/visualMap/continuousLabelOverlap.test.ts→ 3 passed.npx jest --config test/ut/jest.config.cjs→ 28 suites / 199 tests passed, no regressions.Notes
No runtime code is touched — this is coverage-only, so it is safe to land regardless of release timing.