Repository navigation
docs(release): point the download link to the real page - #1241
Merged
Merged
Conversation
The announcement template linked to /download/fesod/, which returns 404. The download page is served by the docs plugin at /docs/download; there is no top-level /download route. Note that /download and /download/ also return 404, so guessing the shorter URL does not help - only the /docs path exists.
GOODBOY008
force-pushed
the
fix/release-download-link
branch
from
October 20, 2026 02:29
fa9bf6b to
681776a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release announcement template links to a page that does not exist:
The download page is served by the docs plugin at
/docs/download. There is no top-level/downloadroute either —/downloadand/download/both return 404, so the intuitive shorter URL does not help.Because this block is the announcement mail template, every release sends the dead link to
announce@apache.organd on to the mirrors.Change
website/community/release/release-version.md:715and the Chinese translation at the same line:Both files are updated together; the sentence lives inside the mail template code block and is intentionally identical in the Chinese file.
Verification
https://fesod.apache.org/download/fesod/(before)https://fesod.apache.org/docs/download(after)The target page is the real one:
<h1>Download Apache Fesod (Incubating)</h1>, listing 2.1.0-incubating with source tarball,.asc,.sha512and the KEYS link.Risk
None. Text-only change inside an email template; no build or behaviour impact.
Regression guard
This is the kind of link nothing currently catches. Docusaurus checks internal routes only (
onBrokenLinks: 'throw'is the v3 default), and there is no external link check in CI — which is why the dead link survived several releases.A follow-up change adds
lycheetoci-docs.ymlso a dead link anywhere underwebsite/**/*.mdfails CI. That checker is deliberately not part of this PR: fixing the document and adding CI infrastructure are two different review concerns, and mixing them makes both harder to review and to revert.