Repository navigation
fix(tools): fail migration on backup data-page errors - #850
Merged
imbajin merged 2 commits intoOct 25, 2026
Merged
Conversation
3 of 11 tasks
MrJs133
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Before: A failed vertex or edge data-page request could be logged and swallowed during backup. Migration could then restore an incomplete export to the target.
After: Propagate exhausted page and asynchronous shard failures through the existing task error handling, so migration stops before starting target restoration. Keep partial output and failed-shard diagnostics for investigation.
Validation and boundaries
The source PR reports 20 backup, restore, retry and safety tests, a Java 17 distribution build, and CLI fault injection that exits nonzero with no target requests. These results are author-reported, not independent upstream or full-cluster upgrade acceptance. Review follow-ups remain for preserving diagnostic files across retries and retaining actionable shard-failure hints.
Source proposal: 🔗 hugegraph/hugegraph-toolchain#96.
Related upgrade work: ASF issue #3224, 🔗 apache/hugegraph#3330.
Paired guidance: 🔗 apache/hugegraph-doc#523.
Visual overview
Backup page and asynchronous shard failures propagate to stop migration before target restoration. Diagnostic retention across retries and actionable failure hints remain review follow-ups; no full-cluster or RC acceptance is implied.