Repository navigation
fix(hubble): distinguish unstyled vertex labels with stable colors - #855
Merged
imbajin merged 1 commit intoOct 25, 2026
Merged
Conversation
MrJs133
approved these changes
Oct 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
============================================
+ Coverage 51.79% 53.79% +1.99%
+ Complexity 5309 3463 -1846
============================================
Files 619 282 -337
Lines 31606 19242 -12364
Branches 3945 2891 -1054
============================================
- Hits 16370 10351 -6019
+ Misses 13750 7788 -5962
+ Partials 1486 1103 -383 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 25, 2026
fix(hubble): distinguish unstyled vertex labels with stable colors
hugegraph/hugegraph-toolchain#100
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels imported through the Server API without a saved
~stylecurrently share the same blue, so the canvas and legend do not distinguish Person, Team and Project. Generate a deterministic palette color from the vertex-label name only when~styleis absent. Default reads remain read-only.All non-null saved styles keep the existing parsing path, including explicit blue, partial styles and historical Hubble-created blue defaults. Those historical defaults cannot be distinguished from a user's choice, so they are preserved. The palette is finite and does not promise collision-free colors for unlimited labels; the existing legend text remains visible.
Validation:
#785FC1, Team#16817D, Project#B07724. The canvas and text-labelled legend were visually checked. Direct Server schema readback still had no saved~stylefor these labels.Screenshot comparison: the before and after captures use the same
community_01query and real 125-vertex/250-edge result, captured before a separate temporary CRUD probe. The graph has since been restored to exactly 3,000 vertices and 6,000 edges, with full normalized data hashes and schema matching the initial baseline. Before: all three labels blue. After: purple Person, teal Team and ochre Project, with readable legend text. A second after capture confirms the colors after page reload oncommunity_02.Screenshot binaries, browser receipts and logs remain outside Git under the user's explicit instruction. The regression and screenshot record requires Page access; GitHub-native image upload is unavailable in this session. The paired before/after captures, page-reload capture and read-only verification record are published together in issue 38 · 默认多标签同蓝 on that Page (publication read back at revision 108). These are private Page attachments, not anonymous GitHub image URLs.
Based on freshly verified org and ASF master
8eb5de9009d494842f6b8ee58b83e1f1248c8aff. Verified source head:6c34884bd9987c5ac02ae6ac5b26e6231dac1efd. The change is three files, 140 additions and one deletion.Source review: hugegraph#100
Visual overview
Absent vertex-label styles receive deterministic palette colors without persisting defaults. Non-null saved styles, including historical blue and partial styles, keep their existing parsing path. The finite palette may collide; legend text remains essential. Conceptual illustration, not a screenshot or scalability/RC acceptance.