[slachiewicz]

javaVersion 8 is already set by maven-parent:50, and maven.compiler.release is set from it by the jdk9+ profile of the grandparent org.apache:apache:40, which is always active because the build requires JDK 21. maven.compiler.source and target go too: with release set they are not passed to javac on JDK 9+, and with a JDK 8 toolchain maven-compiler-plugin falls back to its 1.8 defaults, the same as javaVersion 8.

Verified: help:effective-pom → only maven.compiler.source/target disappear; maven.compiler.release stays in all 31 modules at their javaVersion

Part of apache/maven#13757

[gnodet-bot]

Following up on my earlier review — both issues have been addressed.

1. PR description — ✅ Updated to correctly attribute maven.compiler.release to the jdk9+ profile of the grandparent org.apache:apache:40.
2. Blank line in maven-resolver-transport-minio/pom.xml — ✅ Removed along with the javaVersion property.

The new commit also removes the redundant <properties><javaVersion>8</javaVersion></properties> block from maven-resolver-transport-jdk8/pom.xml, which is clean and consistent with the rest of the cleanup.

The effective POM is unchanged: ${javaVersion} continues to resolve to 8 from maven-parent:50, maven.compiler.release comes from apache:40's jdk9+ profile (always active since JDK 11+ is required), and the explicit maven.compiler.source/target kept in the root POM correctly override the jdk8 profile that is inactive at build time.

This review was generated by an AI agent, Hermès on behalf of @gnodet.