Skip to content

Correct third-party code provenance and licensing - #5593

Open
dajiaohuang wants to merge 2 commits into
apache:masterfrom
dajiaohuang:w9-openwhisk-5588-5591
Open

dajiaohuang wants to merge 2 commits into
apache:masterfrom
dajiaohuang:w9-openwhisk-5588-5591

Conversation

@dajiaohuang

Copy link
Copy Markdown

Description

This addresses the provenance and license-recording issues in #5588, #5589, #5590, and #5591:

  • Replace the Stack Overflow-attributed Unzip traversal with a direct ZipInputStream/NIO loop; add a synthetic nested-entry regression test.
  • Correct the bundled wrapper-script version in LICENSE.txt to Gradle 6.9.1.
  • Record the Akka Streams Sink.combine adaptation and its copyright/license attribution.
  • Rewrite printErr formatting so it no longer relies on the Scallop-derived snippet.

Validation: git diff --check passed; :tools:admin:compileScala passed; an isolated task-local Scala probe compiled Unzip.scala and extracted synthetic nested entries with the expected contents. The focused Gradle :core:standalone:test --tests org.apache.openwhisk.standalone.UnzipTests did not reach the test: on this Windows host, :core:scheduler:generateProto failed because protoc-gen-pekkoGrpc could not be found. No Docker/WSL test was run.

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations.
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@dgrove-oss dgrove-oss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for the PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants