Repository navigation
Conversation
cbcbq
force-pushed
the
bugfix/http-lookup-executor-leak
branch
from
November 6, 2026 03:32
e3e5ef5 to
3b4de8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With HTTP(S) service URLs,
HTTPLookupServiceowns a private executor that is never closed. Its detached worker retains itself after Client destruction, causing threads to accumulate as Clients are repeatedly created, used and destroyed.Modifications
Close the executor provider with
close(0)in theHTTPLookupServicedestructor. Nonblocking shutdown avoids waiting for the same worker when a lookup task releases the final service reference.Verifying this change
Added three regression tests covering:
Client::close().These tests require no broker and can be selected with
--gtest_filter='LookupServiceTest.httpLookup*'.Documentation
doc-not-neededThis change fixes internal executor lifecycle management.