Skip to content

SOLR-16398 | Fix for JsonNL in v1 response of Commits - #5240

Merged
epugh merged 7 commits into
apache:mainfrom
jaykay12:fix-json-nl
Oct 31, 2026
Merged

SOLR-16398 | Fix for JsonNL in v1 response of Commits#5240
epugh merged 7 commits into
apache:mainfrom
jaykay12:fix-json-nl

Conversation

@jaykay12

@jaykay12 jaykay12 commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-16398

Description

Fix for JsonNL in V1 response to ensure non-breaking response

Solution

Used Cursor for approach, code is fully vetted by Jalaz Kumar.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.

No CL needed here.

@jaykay12

jaykay12 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

This is Draft PR for now, acting as placeholder/follow-up for: #5217 (comment)

@epugh

epugh commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

just trigger build

@jaykay12 jaykay12 changed the title [] | Fix for JsonNL in v1 response of Commits SOLR-16398 | Fix for JsonNL in v1 response of Commits Oct 29, 2026
@jaykay12

jaykay12 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/no-changelog

@jaykay12

jaykay12 commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author
Scenario Main Proposed
V1 Get Commits Screenshot 2026-10-30 at 2 44 26 AM Screenshot 2026-10-30 at 2 42 13 AM
- - -
V1 Get Replication Details Screenshot 2026-10-30 at 2 44 45 AM Screenshot 2026-10-30 at 2 42 03 AM

@nick-boss-tech @jaykay12
SOLR-16398: Add regression test for v1 replication commits response s…
1116c2d 
…hape

The v1 command=commits response must keep rendering each commit as a NamedList
(a flat name/value array by default), not a map. This test fails on the PR head
9599df2 and passes on its base 07fdebd.
@github-actions github-actions Bot added the tests label Oct 29, 2026
@jaykay12
jaykay12 marked this pull request as ready for review October 29, 2026 21:21
jaykay12
jaykay12 commented Oct 29, 2026
View reviewed changes

@jaykay12 jaykay12 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review ✅
local testing ✅

I cherry-picked @nick-boss-tech commit via: #5217 (comment)

@epugh we can trigger workflows on this now.

@epugh epugh self-assigned this Oct 30, 2026
@epugh epugh added this to the 10.x milestone Oct 30, 2026
@epugh
epugh merged commit 721c13e into apache:main Oct 31, 2026
4 checks passed
@jaykay12
jaykay12 deleted the fix-json-nl branch October 31, 2026 18:31
dsmiley pushed a commit that referenced this pull request Nov 1, 2026
@jaykay12 @nick-boss-tech @dsmiley
SOLR-16398 | Fix for JsonNL in v1 response of Commits (#5240)
eb742ad 
Co-authored-by: Nick Shanin <nick.boss.us@gmail.com>
(cherry picked from commit 721c13e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@epugh epugh

Labels

no-changelog tests

Projects

None yet

Milestone

10.x

Development

Successfully merging this pull request may close these issues.

3 participants

@jaykay12 @epugh @nick-boss-tech