[lukaszlenart]

Fixes WW-5811

What changes

HTML5 constraint derivation (struts.ui.html5.constraints, html5 theme) now covers temporal controls:

• min/max on date controls from a range validator whose bounds are LocalDate (localdate, WW-5816) or java.util.Date (date), written as yyyy-MM-dd.
  • A java.util.Date bound is reduced to its calendar date in the default time zone, which is the zone DateConverter parses the submitted yyyy-MM-dd in.
  • Dropping the time never makes the browser stricter than the server. With a min of 10:00 on the 1st, the browser allows the 1st and the server rejects it, which is the permitted direction. A max day submits as midnight, which is ≤ max.
  • Years outside 0001–9999 are skipped. LocalDate.toString() writes +10000-…, which is not a valid HTML date.
• required on temporal controls (date, month, week, time, datetime-local) from a required validator, when the bound property's declared type converts "" to null:
  • The types are java.util.Date and its subclasses, Calendar, LocalDate, LocalDateTime, LocalTime and OffsetDateTime.
  • An empty submit then fails on both sides.
  • A String property keeps "" and so still gets no required.

Design decisions (agreed on the ticket discussion)

• Scope is cut to the date control for ranges. No built-in converter and range validator pair round-trips the other temporal controls:
  • datetime-local submits without seconds, which java.util.Date does not parse.
  • time has no LocalTime range validator.
  • month and week have no converter at all.
  • Emitting attributes nothing on the server matches would be untestable, so these controls are left for a future ticket if wanted.
• SPI compatibility. HtmlConstraintProvider (public since 7.4.0) gains a default constraintsFor(..., Class<?> propertyType) overload that delegates to the 7.4.0 method, so existing providers compile and behave unchanged. UIBean calls the new overload.
• Fixed list of types, not a trial conversion. The list lives in the protected convertsBlankToNull(Class), so an app whose own converter maps "" to a value can override one method.
• Property type lookup. Form.getPropertyType resolves the type on the object parameter binding writes to (the pushed model, then the action). It then walks declared types, so a null intermediate object such as a not-yet-created user does not hide it. An indexed or unknown path gives null, which means no required.
• Existing protected method signatures are untouched. The new behaviour lives in new methods (addDateRange, addTemporalRequired, convertsBlankToNull), so subclass overrides keep being called.

Migration note for 7.5.0

A subclass of StrutsHtmlConstraintProvider that overrides the public 4-argument constraintsFor is now bypassed, because the framework calls the 5-argument overload. Such a subclass should override the 5-argument method instead. Providers that implement the interface directly are unaffected.

Tests

• StrutsHtmlConstraintProviderTest:
  • LocalDate and java.util.Date bounds. The Date case pins Asia/Tokyo with a bound whose UTC date differs, so it cannot pass vacuously on a UTC machine.
  • Years out of range, and the other temporal controls getting no min/max.
  • required for each listed type on each temporal control.
  • No required for String, for an unknown type, or on a text control.
  • A provider implementing only the 4-argument method still receives the call.
• ConstraintAttributesTest: the property type handed to the provider for a top-level field, a nested field through null objects, a model-driven field, and indexed and unknown fields.
• Html5ConstraintRenderingTest:
  • Replaces testRendersNoRequiredOnADateTextField, as the ticket asks.
  • Covers datetextfield and textfield type="date" rendering required, min and max, and a String-bound date input rendering no required.
• The rendering tests were checked by mutation: disabling the type check or the date-range branch fails them.
• Full core suite passes on JDK 17 and JDK 25 (3610 tests).

Docs: a struts-site PR follows for core-developers/client-side-validation.md, whose mapping table still says date ranges are deferred.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

Derived constraints can reject server-valid submissions, and date-range dispatch bypasses existing protected overrides.

4 open issues

• Resolve validators from the form submission action · New
• Preserve protected addRange overrides for DATE fields · New
• Prevent derived min from shifting the step grid · New
• Use proleptic Gregorian semantics for date bounds · New

What changed in this PR

Extends Struts’ HTML5 constraint derivation to temporal controls, using validators and declared property types to generate browser attributes.

Changes:

• Derives date min/max bounds and type-aware temporal required attributes.
• Adds a property-type-aware provider overload and binding-type lookup.
• Expands provider, property-resolution, and rendering tests.

File	Description
core/​src/​test/​resources/​org/​apache/​struts2/​components/​ConstraintAction-validation.xml	Adds temporal validation fixtures.
core/​src/​test/​java/​org/​apache/​struts2/​views/​jsp/​ui/​Html5ConstraintRenderingTest.java	Tests rendered date bounds and required attributes.
core/​src/​test/​java/​org/​apache/​struts2/​components/​StrutsHtmlConstraintProviderTest.java	Covers temporal constraints and provider compatibility.
core/​src/​test/​java/​org/​apache/​struts2/​components/​ConstraintAttributesTest.java	Tests property types passed to providers.
core/​src/​test/​java/​org/​apache/​struts2/​components/​ConstraintAction.java	Adds date and string fixture properties.
core/​src/​main/​java/​org/​apache/​struts2/​components/​UIBean.java	Passes property types to constraint providers.
core/​src/​main/​java/​org/​apache/​struts2/​components/​StrutsHtmlConstraintProvider.java	Implements temporal constraint derivation.
core/​src/​main/​java/​org/​apache/​struts2/​components/​HtmlControlType.java	Adds temporal-control classification.
core/​src/​main/​java/​org/​apache/​struts2/​components/​HtmlConstraintProvider.java	Adds the property-type-aware overload.
core/​src/​main/​java/​org/​apache/​struts2/​components/​Form.java	Resolves declared binding-property types.

_{Review effort: Balanced}

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud