[CCCLL]

For the creates inside a multi, AuditHelper looked up the create mode in a map keyed by the requested path. The lookup missed in two cases, so those audit entries were written without znode_type:

• sequential nodes, because the result carries the actual path (/node-0000000005) rather than the requested one (/node-);
• TTL nodes, because createTTL ops were never put into the map.

The same creates outside a multi are logged with znode_type=persistent_sequential and znode_type=persistent_with_ttl (the latter since ZOOKEEPER-4725). The path lookup dates back to the introduction of the audit log in ZOOKEEPER-1260.

A multi yields exactly one result per op, in order (PrepRequestProcessor builds one txn per op and DataTree appends one result per txn), so the create mode is now taken from the op at the same position. That covers both cases, and the path map is removed.

Testing

• New Slf4JAuditLoggerTest#testMultiOperationCreateModeAuditLogs creates a sequential node and a TTL node in one multi and checks that both entries carry znode_type; it fails without the fix and passes with it.
• Slf4JAuditLoggerTest, AuditEventTest, StandaloneServerAuditTest, MultiOperationTest and MultiAsyncTransactionTest pass; checkstyle and spotbugs report no issues.
• Manually against a standalone server with zookeeper.audit.enable=true: a multi creating a persistent, a sequential, a TTL and an ephemeral node now logs znode_type for all four entries; before the fix the sequential and TTL entries had none.

[kezhuw]

LGTM