Repository navigation
fix(doctrine): drop the unused doctrine/common requirement - #8838
Merged
Merged
Conversation
Member
|
Thanks! 4.4 only gets security fixes now so I moved this to 5.0, can you rebase on 5.0 (and update the Branch in the description)? Thanks! |
doctrine/common is abandoned on Packagist, and no class from it (ClassLoader, CommonException, Comparable, Proxy\*, Util\*) is used by api-platform/doctrine-common or by the test suite anymore, likely since the ClassUtils removal (api-platform#6331). Requiring it makes every downstream project report an abandoned package on composer install and composer audit. Closes api-platform#8835 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zegui81
force-pushed
the
fix/drop-doctrine-common
branch
from
November 12, 2026 17:00
5ffd8c5 to
8b6be9c
Compare
Author
|
Done, rebased on 5.0 and updated the description. The component suite still passes standalone without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api-platform/doctrine-commonrequiresdoctrine/common(^3.2.2), which is abandoned on Packagist. Every downstream project therefore gets an abandoned-package report oncomposer installand a failingcomposer auditby default.No class from
doctrine/common(ClassLoader,CommonException,Comparable,Proxy\*,Util\*) is referenced insrc/ortests/anymore: everyDoctrine\Common\…match belongs to theApiPlatform\Doctrine\Common\…namespace. The requirement looks like a leftover from theClassUtilsremoval (#6331).This PR drops it from the component's
requireand from the rootrequire-dev. The rootconflictondoctrine/common <3.2.2is left untouched.Component test suite on 5.0 (
src/Doctrine/Common, run standalone withdoctrine/commonno longer installed): OK, 35 tests, 160 assertions (the 3 PHPUnit deprecations are pre-existingany()expectations inPersistProcessorTest).Also checked downstream on a production app (API Platform 4.4.7, Doctrine ORM 3.7, PHP 8.5) with
doctrine/commonremoved: PHPStan level 8 clean,lint:containervalid, full Playwright e2e suite green (148/148).🤖 Generated with Claude Code