Repository navigation
fix(doctrine): ignore unresolved IRIs in ORM IriFilter - #8839
Closed
pysocrates wants to merge 8 commits into
Closed
pysocrates wants to merge 8 commits into
pysocrates wants to merge 8 commits into
Conversation
pysocrates
marked this pull request as draft
November 11, 2026 21:44
pysocrates
marked this pull request as ready for review
November 11, 2026 21:57
Member
|
Thanks! I reworked this a bit: filters don't throw on wrong values by default, they're ignored (validation is the way to go if you want a 400), so instead of a new |
Member
|
Thanks @pysocrates! We took this over in #8844: the root cause is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An invalid IRI can be swallowed by
IriConverterParameterProvider, leaving an unresolved string forIriFilterand causing a server error.Change
Add the optional
throw_invalid_argumentparameter extra property. When enabled, invalid IRI exceptions are propagated for both scalar and array parameters, allowing the default Symfony exception mapping to return HTTP 400. Existing behavior remains unchanged by default; the existingthrow_not_foundoption continues to handle missing resources.The Laravel development dependency constraint also allows MCP bundle 0.15, which resolves the Composer security-advisory blocker affecting the Laravel and PHPStan CI jobs on the base branch.
Fixes #8834
Validation
Documentation: api-platform/docs#2369
Existing upstream CI failures
The Symfony 8.1 and Symfony dev jobs fail in
PatchTest::testPatchRelationbecause a nested PATCH creates a new related entity rather than updating the existing one. The same failure occurs on the unmodified 5.0 base branch: https://github.com/api-platform/core/actions/runs/42815677460/job/129828038883A separate fix for this regression is already open: #8825