Repository navigation
perf(symfony): remove redundant property info cache files - #8846
Closed
nicolas-grekas wants to merge 1 commit into
Closed
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
nicolas-grekas
force-pushed
the
perf/remove-property-info-cache-files
branch
from
November 13, 2026 13:11
d93704e to
0a9f203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CachedPropertyMetadataFactoryandCachedPropertyNameCollectionFactorystill use the persistentapi_platform.cache.metadata.propertypool (cache.system). A hit there skips PropertyInfo. This PR moves only the inner PropertyInfo cache to memory, keeping repeated calls fast within a PHP process.A fresh docs test wrote 41 system cache files instead of 228, with 187 PropertyInfo files gone. Direct PropertyInfo calls in a new process can be slower: 180 calls took about 140 ms in this fixture, versus 18 ms with files.
ApiPlatformExtensionTest::testPropertyInfoUsesInMemoryCache()checks the cache configuration.