Repository navigation
Conversation
github-actions
Bot
added
the
t-tooling
apify-service-account
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
==========================================
+ Coverage 93.11% 93.14% +0.02%
==========================================
Files 54 54
Lines 3691 3719 +28
==========================================
+ Hits 3437 3464 +27
- Misses 254 255 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apify-factory
left a comment
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, one question about the lookup location.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 15/16 — file-extensions |
| Review findings | ❌ not clean |
| Reviewer escalation | ✅ none |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
file-extensions: disallowed extension: docs/02_concepts/02_actor_input.mdx
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 27b3e03de · workflow run
apify-factory
left a comment
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 15/16 — file-extensions |
| Review findings | ✅ none |
| Reviewer escalation | ✅ none |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
file-extensions: disallowed extension: docs/02_concepts/02_actor_input.mdx
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 27b3e03de · workflow run
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
vdusek
changed the title
Actor.get_input looks inside the storage directory even on non-fs storage backends
…stead of the storage root
|
@Pijukatel see apify/apify-sdk-js@4fabbeb — I made |
…e and in the working directory Mirrors apify/apify-sdk-js@4fabbeb (apify-sdk-js#826). Locally, an input in the default key-value store (a record, or a file in its directory under the storage directory) next to an INPUT / INPUT.json file in the working directory now raises a RuntimeError instead of picking one. In 4.1.0 the store record silently won over the working-directory file, so a local project that has both files now fails with an error telling the user to keep only one. Runs on the Apify platform are not affected.
apify-factory
left a comment
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a human review is active (vdusek: APPROVED, janbuchar: CHANGES_REQUESTED).
| check | result |
|---|---|
| Static gates | ❌ 15/16 — file-extensions |
| Review findings | ✅ none |
| Reviewer escalation | ❌ The public Actor.get_input contract changes: an input record in the default key-value store next to a working-directory input file now raises RuntimeError instead of the store record winning, which can break existing local setups. |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
file-extensions: disallowed extension: docs/02_concepts/02_actor_input.mdx
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 8443f751c · workflow run
Parity with apify/apify-sdk-js#811
Closes: #682