Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions apps.html
Original file line number Diff line number Diff line change
Expand Up @@ -1424,7 +1424,7 @@ <h3>Chaos - Stranger Missions</h3>
ai: ['debate-me','voice-memo','future-me','date-pilot','global-news','pantry-ai','name-maker','idea-market','life-trace']
};
const clean = value => value.normalize('NFKC').toLocaleLowerCase().trim();
let goal = 'all', loggedSearch = false;
let goal = 'all', lastReportedSearch = '';
const slug = card => {
const src = card.querySelector('img')?.getAttribute('src') || '';
return src.split('/').pop()?.replace(/\.png$/, '') || '';
Expand All @@ -1448,19 +1448,25 @@ <h3>Chaos - Stranger Missions</h3>
empty.hidden = shown !== 0;
return shown;
}
input.addEventListener('input', () => {
const shown = render();
// Search strings might include personal details. Never transmit them.
if (input.value.trim() && !loggedSearch) {
fire('catalog_search_used', {results: shown, search_length_band: input.value.length < 5 ? 'short' : 'long'});
loggedSearch = true;
}
if (!input.value.trim()) loggedSearch = false;
// Do not report the unfinished first keystroke as a completed search.
// Keep query text local; GA4 receives only a coarse length bucket and result count.
const reportSearch = () => {
const query = clean(input.value);
if (!query || query === lastReportedSearch) return;
fire('catalog_search_used', {
results: render(), search_length_band: query.length < 5 ? 'short' : 'long'
});
lastReportedSearch = query;
};
input.addEventListener('input', render);
input.addEventListener('blur', reportSearch);
input.addEventListener('keydown', event => {
if (event.key === 'Enter') reportSearch();
});
reset.addEventListener('click', () => {
input.value = '';
goal = 'all';
loggedSearch = false;
lastReportedSearch = '';
buttons.forEach(button => button.setAttribute('aria-pressed', String(button.dataset.goal === 'all')));
render();
input.focus();
Expand Down
7 changes: 7 additions & 0 deletions scripts/check_growth_live.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ def check(path, key, valid):
check("/apps", "no_stale_live_store_claim", "92 free apps on Google Play" not in catalog)
check("/apps", "store_click_tracking", "catalog_store_click" in catalog and "download_click" in catalog)
check("/apps", "detail_click_tracking", "catalog_app_detail_click" in catalog)
check("/apps", "finalized_search_analytics",
"input.addEventListener('input', render)" in catalog and
"input.addEventListener('blur', reportSearch)" in catalog and
"if (event.key === 'Enter') reportSearch()" in catalog and
"query === lastReportedSearch" in catalog and
"lastReportedSearch = query" in catalog and
"loggedSearch" not in catalog)
check("/apps", "search_includes_app_slug",
"const app = slug(card), content = clean((card.textContent || '') + ' ' + app" in catalog
and "app.replace(/-/g, ' ')" in catalog)
Expand Down
21 changes: 21 additions & 0 deletions scripts/test_growth_live.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ def valid_pages():
pages["/apps"] = (
'<script type="application/ld+json">' + json.dumps(listing) + '</script>' +
cards + " catalog_store_click download_click catalog_app_detail_click " +
"input.addEventListener('input', render) input.addEventListener('blur', reportSearch) " +
"if (event.key === 'Enter') reportSearch() query === lastReportedSearch " +
"lastReportedSearch = query " +
"const app = slug(card), content = clean((card.textContent || '') + ' ' + app; app.replace(/-/g, ' ')" +
'id="finder-reset" reset.addEventListener(\'click\' input.value = \'\' goal = \'all\' render(); catalog_search_reset ' +
" ".join(f'<a href="/support/{slug}/" data-detail-app="{slug}">' for slug in SLUGS)
Expand Down Expand Up @@ -187,6 +190,24 @@ def test_store_schema_package_mismatch_fails(self):
"id=jp.appdevelopsk.testapp1", "id=jp.appdevelopsk.unlisted", 1)
self.assertFalse(inspect(data)["passed"])

def test_first_keystroke_analytics_rejected(self):
data = valid_pages()
data["/apps"] = data["/apps"].replace(
"input.addEventListener('input', render)",
"input.addEventListener('input', reportSearch)")
self.assertFalse(inspect(data)["passed"])

def test_missing_blur_search_reporting_rejected(self):
data = valid_pages()
data["/apps"] = data["/apps"].replace(
"input.addEventListener('blur', reportSearch)", "")
self.assertFalse(inspect(data)["passed"])

def test_repeated_search_reporting_rejected(self):
data = valid_pages()
data["/apps"] = data["/apps"].replace("query === lastReportedSearch", "")
self.assertFalse(inspect(data)["passed"])

def test_missing_slug_search_fails(self):
data = valid_pages()
data["/apps"] = data["/apps"].replace(
Expand Down
Loading