Skip to content

feat(analytics): attribute editorial-guide visitors to filtered app results #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appdevelopsk merged 2 commits into from
Nov 6, 2026
Merged

feat(analytics): attribute editorial-guide visitors to filtered app results #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d8b12
feat(analytics): attribute allowlisted editorial-guide visits to cata…
appdevelopsk Nov 6, 2026
f96eed6
test(analytics): keep guide arrival measurement separate and privacy …
appdevelopsk Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,14 @@ <h3>Chaos - Stranger Missions</h3>
app_slug: app, source: 'apps_catalog'
});
}));
render();
const initialResults = render();
// Track editorial-guide arrivals separately from manual category choices.
// Only the allowlisted category and count are sent; no search terms.
if (goal !== 'all') {
fire('catalog_filter_landing', {
goal, results: initialResults, source: 'editorial_guide'
});
}
})();
</script>
</body>
Expand Down
8 changes: 8 additions & 0 deletions scripts/test_guide_catalog_links.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ def test_catalog_filter_buttons_cover_guides(self):
with self.subTest(goal=goal):
self.assertIn(f'data-goal="{goal}"', catalog)

def test_guide_landing_has_separate_privacy_safe_event(self):
catalog = (ROOT / "apps.html").read_text(encoding="utf-8")
self.assertIn("const initialResults = render();", catalog)
self.assertIn("if (goal !== 'all')", catalog)
self.assertIn("fire('catalog_filter_landing'", catalog)
self.assertIn("goal, results: initialResults, source: 'editorial_guide'", catalog)
self.assertNotIn("query: input.value", catalog)

def test_catalog_cards_and_details_preserved(self):
catalog = (ROOT / "apps.html").read_text(encoding="utf-8")
self.assertEqual(len(re.findall(r'class="app-card"', catalog)), 92)
Expand Down
Loading