Skip to content

fix(catalog): keep manually selected app categories shareable after reload #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appdevelopsk merged 2 commits into from
Nov 6, 2026
Merged

fix(catalog): keep manually selected app categories shareable after reload #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f146962
fix(catalog): keep selected category deep link in sync with UI
appdevelopsk Nov 6, 2026
dfaa577
test(catalog): guard deep-link sync and privacy of manual filters
appdevelopsk Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,6 +1437,13 @@ <h3>Chaos - Stranger Missions</h3>
const src = card.querySelector('img')?.getAttribute('src') || '';
return src.split('/').pop()?.replace(/\.png$/, '') || '';
};
// Keep the selected purpose shareable across reloads without exposing search text.
const syncGoalUrl = () => {
const url = new URL(window.location.href);
if (goal === 'all') url.searchParams.delete('goal');
else url.searchParams.set('goal', goal);
window.history.replaceState(window.history.state, '', url.pathname + url.search + url.hash);
};
const fire = (event, data) => {
if (typeof window.gtag === 'function') window.gtag('event', event, data);
};
Expand Down Expand Up @@ -1476,13 +1483,15 @@ <h3>Chaos - Stranger Missions</h3>
goal = 'all';
lastReportedSearch = '';
buttons.forEach(button => button.setAttribute('aria-pressed', String(button.dataset.goal === 'all')));
syncGoalUrl();
render();
input.focus();
fire('catalog_search_reset', {source: 'empty_state'});
});
buttons.forEach(button => button.addEventListener('click', () => {
goal = button.dataset.goal;
buttons.forEach(b => b.setAttribute('aria-pressed', String(b === button)));
syncGoalUrl();
fire('catalog_filter_used', {goal, results: render()});
}));
document.querySelectorAll('[data-detail-app]').forEach(link => {
Expand Down
17 changes: 17 additions & 0 deletions scripts/test_guide_catalog_links.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,23 @@ def test_missing_baseline_app_is_rejected(self):
cards = '<a class="app-card"></a>' * (MIN_CATALOG_CARDS - 1)
self.assertFalse(catalog_card_count_ok(cards))

def test_manual_filter_syncs_shareable_goal_url(self):
catalog = (ROOT / "apps.html").read_text(encoding="utf-8")
self.assertIn("const syncGoalUrl = () =>", catalog)
self.assertIn("url.searchParams.set('goal', goal)", catalog)
self.assertIn("url.searchParams.delete('goal')", catalog)
self.assertIn("window.history.replaceState(", catalog)
self.assertIn("url.pathname + url.search + url.hash", catalog)
self.assertEqual(catalog.count(" syncGoalUrl();"), 2)

def test_filter_url_does_not_capture_private_search_text(self):
catalog = (ROOT / "apps.html").read_text(encoding="utf-8")
start = catalog.index("const syncGoalUrl = () =>")
end = catalog.index(" const fire =", start)
sync_code = catalog[start:end]
self.assertNotIn("input.value", sync_code)
self.assertNotIn("find-app", sync_code)

def test_catalog_cards_and_details_preserved(self):
catalog = (ROOT / "apps.html").read_text(encoding="utf-8")
self.assertTrue(catalog_card_count_ok(catalog), "app catalog fell below the 92-card baseline")
Expand Down
Loading