Repository navigation
fix(analytics): separate actual editorial-guide referrals from shared category links - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
catalog_filter_landinglabels every/apps?goal=...load assource=editorial_guide, including direct, bookmarked, and shared URLs. This falsely attributes traffic to our four guides. New logic compares only same-origindocument.referrerpath to the specific allowed guide matching the goal; reports source=editorial_guideonly when matched and otherwisedirect_or_shared, including suppressed/malformed referrers. No raw referrer URL or search text is sent to GA4. Existing 92 Play cards, five detail links, and manual category events unchanged. Update offline source regression test and add matching-guide guard; now ten Python test methods in that module, not executed in container. Locally executed a Node.js equivalent logic test with 9/9 cases (four guide types, missing/invalid/cross-origin/wrong guide cases). No GitHub Actions, deployment, or proof of GA4 delivery.