Repository navigation
fix(analytics): count repeated catalog searches after clearing the input - #77
Merged
appdevelopsk merged 3 commits intoNov 7, 2026
Merged
Conversation
appdevelopsk
marked this pull request as ready for review
November 7, 2026 00:16
7 tasks
appdevelopsk
added a commit
that referenced
this pull request
Nov 7, 2026
… and unit gates The deployed pages were correct but the gates still pinned old values: - check_growth_live: #77 input handler (clears dedupe key, never reports per keystroke) - check_app_discovery_live: #78 Debate Me title, #53 robots Allow: /icons/ - catalog-growth: #71 ?goal= landing needs URL/location/history/reset in sandbox; #63 app_detail_click - debate-me / dotchi: current title; sitemap lastmod must not regress (not equal a fixed date) python 72/72, node tests 52/52 (was 47/52 on main), live 92/92. Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV
appdevelopsk
added a commit
that referenced
this pull request
Nov 7, 2026
…78/#79 (#83) * fix(deploy): publish TaleTime and Dog Breeds support pages updated in #78/#79 sitemap.xml (#81) advertises lastmod 2026-11-07 for both pages, but publish_app_discovery.sh did not list them, so --apply would ship the new sitemap while leaving their old HTML live. Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV * test(release): follow intentional #53/#63/#71/#77/#78 changes in live and unit gates The deployed pages were correct but the gates still pinned old values: - check_growth_live: #77 input handler (clears dedupe key, never reports per keystroke) - check_app_discovery_live: #78 Debate Me title, #53 robots Allow: /icons/ - catalog-growth: #71 ?goal= landing needs URL/location/history/reset in sandbox; #63 app_detail_click - debate-me / dotchi: current title; sitemap lastmod must not regress (not equal a fixed date) python 72/72, node tests 52/52 (was 47/52 on main), live 92/92. Claude-Session: https://claude.ai/code/session_01J5anYNmtTi1EKefKjB5aoV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a real catalog analytics undercount: after searching for a term, clearing via the built-in HTML search-input × control, then re-entering the same term,
lastReportedSearchstill held the previous query, so the newcatalog_search_usedevent was skipped. Theinputhandler now resets deduplication when the normalized field is blank, while preserving live filtering and Enter/blur deduplication. No raw search term is transmitted. Addsscripts/test_catalog_search_events.cjs, which extracts and executes the actual input/reporting handlers fromapps.htmlin a Node VM, with six regression cases covering unfinished typing, Enter+blur deduplication, clear/repeated search, empty submission, repeated blur, and no raw query disclosure. 6/6 Node tests passed locally with test file blob7b66ad289a328ffe6e11b66aa7903e5240ad6068, exactly matching GitHub branch. Source-level checks confirm 92 Play cards and 5 app spotlight links unchanged. README manual QA runbook updated. No GitHub Actions; no live browser, GA4 DebugView, store publication, or install lift claimed.