Repository navigation
fix(analytics): include editorial guide Play clicks in unified download funnel - #85
Merged
Merged
Conversation
appdevelopsk
marked this pull request as ready for review
November 7, 2026 09:28
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The four editorial guides emitted only legacy
guide_store_click. As a result, clicks from guide pages could be missing from the site's shareddownload_clickstore-outbound funnel, while homepage, catalog and app support pages already emit the common event. This makes acquisition attribution incomplete.Fix
For all 17 direct Google Play buttons across four guides, retain exactly one
guide_store_clickand add onedownload_clickon the same click.Standardize the event fields
store='google_play',location='guide',placement='guide_card',app_slug, and the allowlisted guide name. Do not send personal data or raw referrer/query strings.Do not alter any Play Store links, their UTM/referrer parameters, or the 17 new first-party
Features & FAQslinks. The new detail links continue emitting only the unifiedapp_detail_clickevent.Verification
Direct source checks on all four GitHub branch HTML blobs passed: one legacy store event listener and one common download event per guide, 17 Play links and 17 matching detail links still present.
Added
scripts/test_guide_store_events.cjswhich executes the actual store-click handler source with Node VM mocks; 8/8 tests passed locally on representative guide HTML, and the test script hash matches GitHub exactly:2c68a19464b864aed75e8b99a96ffa2476a77935.README QA command updated. Full deployed-browser/GA4 DebugView attribution not verified. Two distinct GA4 event names on one click are not two installs. GitHub Actions not used; deployment is owner-controlled.