Skip to content

fix: stabilize size-aware mask and histogram displays - #60

Merged
kgofron merged 1 commit into
areaDetector:masterfrom
kgofron:fix/size-aware-mask-histogram-displays
Sep 29, 2026
Merged

kgofron merged 1 commit into
areaDetector:masterfrom
kgofron:fix/size-aware-mask-histogram-displays

Conversation

@kgofron

@kgofron kgofron commented Sep 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace overlapping fixed-size MaskBPC and BPC image widgets with one dynamically sized widget per image.
  • Select image dimensions, axis limits, widget geometry, visibility, and ROI visibility from PixCount_RBV.
  • Replace the three geometry-specific PixelConfig-difference widgets with one dynamically sized widget.
  • Preserve support for:
    • 256×256;
    • 512×512;
    • 1024×512 detector rasters.
  • Restore a direct Verify BPC action using the existing RefreshPixelConfig PV.
  • Keep the accumulated preview-histogram Y axis in autoscale mode as frame updates arrive.
  • Add the changes and qualification status to the R1-8-0 release notes.

The three driver BOB files are byte-identical to the corresponding screens tested in SNS BOB commit aa500d4.

The SNS-wide _ad_view_image_pva_profiles.bob change remains in the site BOB repository because that shared screen is not shipped or referenced by ADTimePix3.

No driver code, PV names, IOC databases, NDArray addresses, acquisition behavior, or histogram data processing are changed.

Runtime qualification

SNS Phoebus validation passed for:

  • 256×256 mask and PixelConfig-difference displays;
  • 512×512 mask and PixelConfig-difference displays;
  • direct mask-screen operation;
  • preview-histogram accumulation and Y-axis autoscaling.

The 1024×512 mask-display runtime check remains pending and is documented explicitly.

Validation

  • 346/346 deterministic C++ tests passed.
  • 3/3 dependency-report tests passed.
  • 11 implemented coordinate-map cases passed; five planned physical SpIDR 2×4 cases remain deferred.
  • 47/47 Phoebus BOB files parsed successfully as XML.
  • REUSE validation passed for 380/380 files.
  • git diff --check passed.

Hosted CI should confirm the default, AddressSanitizer, and UndefinedBehaviorSanitizer jobs.

@kgofron
kgofron merged commit 0742e15 into areaDetector:master Sep 29, 2026
3 checks passed
@kgofron
kgofron deleted the fix/size-aware-mask-histogram-displays branch September 29, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant