Repository navigation
fix(ide): a log with ANSI colours opens as text, not as binary - #854
Merged
Merged
Conversation
Only a NUL byte or what is not UTF-8 makes a file binary, as in VS Code; other control characters, such as ESC in colour codes, are text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A UTF-8 log with ANSI colour codes (ESC bytes) was refused as binary, since any C0 control character counted as binary. Now only a NUL byte or invalid UTF-8 does, as in VS Code.
Test:
flutter test test/remote/remote_server_test.dart test/ide/workbench/placeholder_test.dartpasses, with a new case for a coloured log.