Repository navigation
Add extra_test_rustc_flag build setting for rust_test - #4359
Open
Spikhalskiy wants to merge 1 commit into
Open
Spikhalskiy wants to merge 1 commit into
Spikhalskiy wants to merge 1 commit into
Conversation
Adds a repeatable build setting whose flags are passed to rust_test only, in the non-exec configuration. They follow extra_rustc_flag and precede the target's own rustc_flags, so a test can still override them.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a repeatable
extra_test_rustc_flagbuild setting that onlyrust_testreads, in the non-exec configuration, as proposed in #4358. Its flags come afterextra_rustc_flagand before the target's ownrustc_flags, so a test can still override them. The setting is target-scoped so that setting it does not change the exec configuration. Onlyrust_testdeclares the attribute that reads it, so libraries and binaries are unaffected.Tested in
test/unit/extra_rustc_flags: the flag reaches arust_testaction before the target's ownrustc_flags, and does not reach arust_library. The new test fails with the flag collection disabled. Theextra_rustc_flags,per_crate_rustc_flagandrustc_flag_orderingsuites pass on Bazel 9.3.0 and the minimum 7.4.1.Fixes #4358