Repository navigation
Reject SELECT columns that no document has - #41
Merged
Merged
Conversation
MongoDB returns an empty document for each match when a projected field doesn't exist, so SELECT invalid_lmao FROM users returned one blank row per document instead of an error (#7). - The compiler records the fields a SELECT list reads on FIND and AGGREGATE commands (selectedFields). Table qualifiers are dropped, paths stop at the first array index, and JOINs are skipped. - The executor throws 'Column "x" does not exist in collection "y"' when no document in the collection has a selected field. execute() only looks up fields that none of the returned rows have a value for; executeCursor() checks before returning the cursor. Fields that only some documents have, and empty collections, are still allowed. - DummyCollection gets a findOne, which the executor already needed for ObjectId detection. Claude-Session: https://claude.ai/code/session_013yzyAbpCE94cknaLBFAtZ7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MongoDB returns an empty document for each match when a projected field
doesn't exist, so SELECT invalid_lmao FROM users returned one blank row
per document instead of an error.
Fix #7
AGGREGATE commands (selectedFields). Table qualifiers are dropped,
paths stop at the first array index, and JOINs are skipped.
no document in the collection has a selected field. execute() only
looks up fields that none of the returned rows have a value for;
executeCursor() checks before returning the cursor. Fields that only
some documents have, and empty collections, are still allowed.
ObjectId detection.
Claude-Session: https://claude.ai/code/session_013yzyAbpCE94cknaLBFAtZ7