Repository navigation
Replace the narrated tour with the version 3 walkthrough - #330
Merged
Merged
Conversation
The product site embedded the version 2 walkthrough and labeled it as historical material. A narrated tour of version 3 is now published, so the demo page presents it as the current tour: new video, captions, poster, chapters and transcript. The music credit for the old soundtrack is removed; the new video does not use that track.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and outcome
The demo page embedded the narrated walkthrough of version 2 inside a collapsed "Historical version 2 narrated tour" block. A narrated tour of version 3 is now published, so the page should show that one as the current tour.
site/video.jsembeds the new video; every "Watch on YouTube" and chapter link onsite/demo.htmlpoints to it.docs/webssh-3.mdno longer describes the narrated video as historical.The opt-in loading, the consent notice, the Content Security Policy and the privacy notice are unchanged.
Scope and links
Related issue/proposal: none, site content only.
Target milestone (if accepted into a release): none.
Validation
pytest tests/test_documentation_surface.py tests/test_public_product_surface.py tests/test_branding.py tests/test_repository_hygiene.py tests/test_license_consistency.py tests/test_ci_change_scope.py: 190 passed.scripts/check_repository_hygiene.pyandscripts/check_license_consistency.pypass. The full suite was not run locally.test_demo_is_opt_in_and_has_local_preview_and_text_alternativesnow expects the new video link, eight chapter times, the 2:17 caption and no "Historical" label.Delivery
Merging implements the change; it does not publish a versioned release.