Repository navigation
BIP-0322: name taproot upgrade mechanisms in the upgradeable rules - #2336
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
jonatack
added
Proposed BIP modification
Contributor
|
ACK. Agree on this being a minor version bump. |
The upgradeable rules list the to_sign version, NOPs reserved for upgrades and segwit versions above 1. BIP341 and BIP342 also reserve unknown leaf versions, OP_SUCCESSx, unknown public key types and the annex for upgrades. A verifier that follows the BIP322 text calls a signature using any of them valid. Name them, so that these give the inconclusive state like the other upgrade mechanisms. Bump the version to 2.1.0 and add a changelog entry. Add 342 to Requires.
jonatack
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP322's upgradeable rules do not name four taproot upgrade mechanisms, so a verifier that follows the text calls a signature using one of them valid. This adds one rule naming them: an unknown leaf version and the annex (BIP341), OP_SUCCESSx and an unknown public key type (BIP342). Such a signature then gets the inconclusive state, as reserved NOPs and segwit versions above 1 already do. The version becomes 2.1.0, as requested in review.
The BIP322 library in btcd#2521 already returns inconclusive for all four, and the gap was raised in its review. I ran its test vectors through btclib-wallet, a verifier I maintain: it agreed on three of the four and called the annex case valid, as the current text says.
cc @guggero @kallewoof