Repository navigation
Keep deploying when the citation fetch is refused or stale - #136
Merged
Merged
Conversation
- A refused SEMANTIC_SCHOLAR_API_KEY is reported as an error (annotation and run summary) and the batch is asked again without the key, instead of failing every run until the secret is fixed. - Both tries share one deadline, and no try starts that could run past it: about five minutes at worst, under the step's eight. - A non-retried 4xx logs its status and body. - Published counts kept for more than 7 days are reported as an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #135, from the review of the deployed feature (no major issue found; these are its minor findings worth fixing).
SEMANTIC_SCHOLAR_API_KEYfailed every run, PR and deploy alike, until the secret was fixed. Now it is reported as an error (an annotation and a line in the run summary) and the batch is asked again without the key.docs/operations.mdis updated to match.Verification:
validate-site.shall pass.