Skip to content

Keep deploying when the citation fetch is refused or stale - #136

Merged
bits-bytes-nn merged 1 commit into
mainfrom
fix/citation-fetch-hardening
Nov 17, 2026
Merged

bits-bytes-nn merged 1 commit into
mainfrom
fix/citation-fetch-hardening

Conversation

@bits-bytes-nn

Copy link
Copy Markdown
Owner

Follow-up to #135, from the review of the deployed feature (no major issue found; these are its minor findings worth fixing).

  • A refused API key no longer fails the run. Before, a refused SEMANTIC_SCHOLAR_API_KEY failed every run, PR and deploy alike, until the secret was fixed. Now it is reported as an error (an annotation and a line in the run summary) and the batch is asked again without the key.
  • Both batch calls share one 240 s deadline. No try starts if it could run past the deadline, so the worst case is about 5 minutes, under the step's 8.
  • A 4xx that is not retried now logs its status and body.
  • Published counts kept for more than 7 days are reported as an error.
  • docs/operations.md is updated to match.

Verification:

  • Unit tests (208), post lint, actionlint, strict build, htmlproofer and validate-site.sh all pass.
  • The refused-key and stale-fallback paths were run with the network stubbed.

- A refused SEMANTIC_SCHOLAR_API_KEY is reported as an error (annotation
  and run summary) and the batch is asked again without the key, instead
  of failing every run until the secret is fixed.
- Both tries share one deadline, and no try starts that could run past
  it: about five minutes at worst, under the step's eight.
- A non-retried 4xx logs its status and body.
- Published counts kept for more than 7 days are reported as an error.
@bits-bytes-nn
bits-bytes-nn merged commit 6a0da42 into main Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant