Repository navigation
Rank search results; review-round fixes - #138
Merged
Merged
Conversation
Search (the one major finding): simple-jekyll-search stopped at the first 10 matches in posting order, so "llama" listed ten posts that mention Llama and none of the three Llama papers. js/search.js now matches and ranks itself: every query word must be in the post; title, tags, category and body hits are weighted, newest first on a tie; a translation pair counts once (search.json `translation`); the status gives the real total and "Show 10 more" adds the rest. The unpkg dependency goes. A one-word miss no longer says "try fewer words". Also: - TOC: a post with fewer than 3 h2s lists its h3s too, indented and unnumbered (RAPTOR, LLaMA, DeepSeek LLM, GraphRAG had none). - Accessibility: dark focus ring on the TOC toggle; 44px share links and phone-menu theme toggle; overflowing equations are groups, not landmarks; lightbox figures stop short of the close button. - MathJax reads only \( \) and \[ \]; the `$$` delimiter was dead. - Social image: width/height read from the file (image_size filter), so covers declare theirs; the hardcoded fb_image sizes go. - JSON-LD names the reviewed paper by DOI (`about`). - Home page: a Korean description. - /paper-reviews/ lists topics in the spec's order, as /categories/ does. - Docs: the :post_read hook order, citations.json in the layout. - Test: "nothing to write" now checks an existing file is left alone.
- search.js ran only when a composition ended, so the last Korean syllable (or a phone keyboard's whole word) was never searched live. Results now follow every keystroke; only the spoken status waits. - Of a translation pair that both match, the post in site.lang is shown. - The h3s a short-h2 post's TOC lists nest under their h2; an h3 before any h2 is listed as a section. - JSON-LD `about` carries the paper's name and DOI identifier. - The phone-menu theme toggle keeps the menu's right edge. - Docs: the date is not searched; composition and pair behaviour.
- The status text updates with the results during IME composition and is spoken (aria-live) once the syllable is done, instead of going stale. - A query typed just before clicking a result is written to ?q= on pagehide, so Back returns to it. - Nested TOC items no longer shrink twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes come out of three rounds of adversarial review covering features, UI/UX, SEO and code hygiene, run over the whole blog.
Major: search hid the posts it should show first
simple-jekyll-search stopped at the first 10 matches in posting order and never ranked them. A search for
llamalisted ten posts that merely mention Llama, and none of the three Llama papers.js/search.jsnow does the matching and ranking itself:site.lang.search.jsonhas a newtranslationfield for this.aria-live) only once the syllable is done.Minor fixes
role=groupinstead of landmarks (one post had 19).\(\)and\[\]. The$$delimiter was dead config; no built page has a literal$$.image_sizefilter. Covers now declare theirs, and the hardcodedfb_image_*sizes are removed.aboutnames the reviewed paper by name and DOI.:post_readhook order, the search behaviour and the math delimiters now match the code.No change to
_data/post_conventions.ymland no new lint rule.Verification
validate-site.shall pass.?q=behave as described.Deliberately not done
These need a decision:
seo_titleon about 15 long-titled generated postsdateModifiedfrom hand fixesdefault.jpgcovers