Repository navigation
test(core): close wallet test gaps found by mutation testing - #357
Merged
Merged
Conversation
zaxovaiko
requested review from
jakubfilinger-b,
klaudia-blazyczek-blurify,
marek-chmielowski-blurify,
mp-blurify and
okapitula
as code owners
October 26, 2026 18:30
zaxovaiko
removed request for
jakubfilinger-b,
marek-chmielowski-blurify,
mp-blurify and
okapitula
October 26, 2026 18:30
zaxovaiko
force-pushed
the
chore/wallet-mutation-tests
branch
from
October 26, 2026 19:00
1032544 to
b1dc11f
Compare
…nd bonus wagering guards
… case cannot flake
…audit after-state
…ay and queue ordering
…and held redelivery
zaxovaiko
force-pushed
the
chore/wallet-mutation-tests
branch
from
October 26, 2026 20:36
b1dc11f to
15995c4
Compare
klaudia-blazyczek-blurify
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recordTimezoneflake (two stamps in the same millisecond).Mutation numbers (wallet, unit + integration, no-coverage / survived, string literals excluded)
wallet.service.ts: 155 / 0 -> 46 / 46. Of the survivors seen in triage, about 40 killed, 41 equivalent, 5 not worth a test.wallet-commands.service.ts: 23 / 5 -> 9 / 6, all 6 equivalent.wallet-reader.service.ts: 18 / 2 -> 0 / 4, 3 equivalent, 1 not worth a test.admin-reporting.ts: 14 / 10 -> 0 / 10, equivalent (an emptyand()).Remaining survivors, why they stay
inArray([])compiles tofalse, so empty-array guards are only shortcuts (service 1994, 2127, 3128; reader 121).?.and!rowchecks never fire (service 2161-2167, 3186-3187; reader 113).openWalletreturn a row either way (commands 134, 313; service 531, 1416-1431, 3651)..setdropsundefined(service 2310-2311); the status re-read returnscompletedanyway (2441-2443).enabledis checked twice (2701); a null threshold fails closed into the same manual queue (2705); the lock tag is still caught (2733).realPartequals the amount (commands 215, 250, 252)..sortPostgres already satisfies (2163).Not covered here
Depends on