Skip to content

Add more accurate calculation of amax for div_par_mod/div_par_fvv - #3528

Open
totork wants to merge 7 commits into
nextfrom
div-par-dissipation
Open

totork wants to merge 7 commits into
nextfrom
div-par-dissipation

Conversation

@totork

@totork totork commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Right now in Fci, amax used for the dissipation in Div_par_mod / Div_par_fvv does not use the wave speed at the interface. This will lead to differences between cells that calculate the flux on the same interface, and hence spurious sources.

This change will require the parallel slices of the wave_speed_in to be set!

@totork totork added breaking change Introduces a change that is not backward compatible with the previous major version FCI and removed breaking change Introduces a change that is not backward compatible with the previous major version labels Oct 27, 2026

@dschwoerer dschwoerer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Does this need changes in hermes-3 to work?

Comment thread include/bout/fv_ops_impl.hxx Outdated
Comment thread include/bout/fv_ops_impl.hxx Outdated
totork and others added 2 commits October 28, 2026 17:09
Co-authored-by: David Bold <dave@ipp.mpg.de>
Co-authored-by: David Bold <dave@ipp.mpg.de>
@totork

totork commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Looks good 👍

Does this need changes in hermes-3 to work?

I think when sound_speed is on it communicates it, which means it should have parallel slices. Without it uses

Field3D fastest_wave; if (state.isSet("fastest_wave")) { fastest_wave = get<Field3D>(state["fastest_wave"]); } else { const Field3D T = get<Field3D>(species["temperature"]); const BoutReal AA = get<BoutReal>(species["AA"]); fastest_wave = sqrt(T / AA); }

Changing this from Field3D to Field3DParallel should do the trick

@totork
totork requested a review from dschwoerer October 28, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants