Repository navigation
Conversation
dschwoerer
reviewed
Oct 28, 2026
dschwoerer
left a comment
Contributor
There was a problem hiding this comment.
Looks good 👍
Does this need changes in hermes-3 to work?
Co-authored-by: David Bold <dave@ipp.mpg.de>
Co-authored-by: David Bold <dave@ipp.mpg.de>
Contributor
Author
I think when sound_speed is on it communicates it, which means it should have parallel slices. Without it uses
Changing this from Field3D to Field3DParallel should do the trick |
dschwoerer
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now in Fci, amax used for the dissipation in
Div_par_mod/Div_par_fvvdoes not use the wave speed at the interface. This will lead to differences between cells that calculate the flux on the same interface, and hence spurious sources.This change will require the parallel slices of the wave_speed_in to be set!