Repository navigation
Avoid spamming options on getYBoundary() - #3530
Open
dschwoerer wants to merge 3 commits into
Open
dschwoerer wants to merge 3 commits into
dschwoerer wants to merge 3 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This is called by Div_par_K_Grad_par_mod without caching.
dschwoerer
force-pushed
the
getyboundary-default
branch
from
October 29, 2026 10:10
7adb40c to
abcae69
Compare
| if (is_default) { | ||
| // populate cache first to avoid race condition | ||
| getYBoundary(lower_y, upper_y); | ||
| default_yboundary = boundary_bools_to_index(lower_y, upper_y); |
Contributor
There was a problem hiding this comment.
warning: narrowing conversion from 'std::size_t' (aka 'unsigned long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
default_yboundary = boundary_bools_to_index(lower_y, upper_y);
^
Contributor
|
Seems to be fixed |
dschwoerer
marked this pull request as ready for review
October 29, 2026 11:59
totork
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is called by Div_par_K_Grad_par_mod without caching.
@totork can you verify this fixes your issue seen in #3522 ?