Repository navigation
Set the HTTPS server variable for HTTPS requests - #2253
Merged
Merged
Conversation
Frameworks detected HTTPS only when they trusted the proxy that sets X-Forwarded-Proto. API Gateway, Function URLs and load balancers set it, and replace the value sent by the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bref did not set
$_SERVER['HTTPS'], so frameworks only detected HTTPS when they trusted the proxy that setsX-Forwarded-Proto. Without that configuration, Laravel and Symfony generatehttp://URLs and drop secure cookies.API Gateway, Function URLs and load balancers set
X-Forwarded-Protothemselves and replace the value sent by the client, so Bref now setsHTTPS=onfrom it, in the PHP-FPM and function runtimes.