Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3850.
pgalready callscork()anduncork()around a parameterized query when the socket supports them.CloudflareSocketlacked those methods, so Parse, Bind, Describe, Execute, and Sync went to its underlying writer in five separate calls.This buffers writes until the last
uncork()and sends their bytes in order as one write. Buffered callbacks receive the write result in order.end()flushes before closing, anddestroy()discards unsent bytes and completes their callbacks with the destruction reason.Validation
masterand pass with the fix. The protocol test checks that five writes become one with identical bytes.workerdagainst PGlite over TCP, parameterized queries used one writer call each. The same connection handled another query after a rejected parameter value. The existing Workers test also passed.pgunit suite, 29 ESM tests, TypeScript build, lint, and webpack, Rollup, Vite, and esbuild checks passed.Production latency was not measured locally. Prepared with AI assistance.