Repository navigation
test: add downloads, export, and type contracts - #206
Draft
derekmeegan wants to merge 1 commit into
Draft
derekmeegan wants to merge 1 commit into
derekmeegan wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Python SDK contract tests from browserbase/browserbase-stlc-config#39 into this repo's CI, for the one-repo flow.
tests/lib/test_downloads.pycovers downloads pagination, metadata, deletion, errors, the legacy ZIP endpoint, streaming without eager reads,stream_to_file(), and cancellation, both sync and async.tests/lib/test_sdk_exports.pycovers the public exports.tests/lib/sdk_types.pyis the type-level contract. pytest doesn't collect it, and./scripts/lintchecks it with pyright.This is stacked on
feat/downloads, the preview build of browserbase/browserbase-stlc-config#75. Retarget it tomainafter #75 merges. Nothing in it edits generated files, and the preview's own CI already passes.The tests now use this repo's pytest settings instead of
unittest: pytest classes,parametrizein place ofsubTest, andtmp_path, with every assertion kept. To pass strict pyright,sdk_types.pygained an__all__for names imported only to prove they exist, and three reads of the not-requiredproject_idcarry a rule-specificpyright: ignore.mypy .excludestests/, so in CI pyright is what checks the type file; running mypy on these files directly also passes.Locally,
./scripts/lintpasses.pytest tests/libpasses 29 tests on Python 3.9 (pydantic v2 and v1) and 3.14. The full./scripts/testalso passes with the mock server.🤖 Generated with Claude Code