Repository navigation
Release 2.1.2: the "keep the source" tick stays where you put it - #6
Merged
Merged
Conversation
Loading a profile on the Convert page filled BOTH pages from the file again. The watched folder lost its own options that way: a "keep the source" ticked there went out, and the next find was moved away. The controls a profile has just set are now written into the file instead, and the watched folder is left alone. "Shut down when finished" no longer comes back from a profile's copy of the file either. A profile's copy of the file is brought into line with the controls it is saved from, and the list of settings is read fresh before saving. A copy that was older than the boxes could contradict the profile's own tick. The watched folder recognises results in the "output" subfolder. With originals kept, every restart of the window handed the whole stock to the converter again. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GvUq7F6HRPWfTUBjDkD1bR
Version 2.1.2 in main.go and wails.json, and the release text. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GvUq7F6HRPWfTUBjDkD1bR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Three places where the window and the files could disagree about whether originals are kept.
applyProfileSettingsused to clearoptionsSeeded, which filled both pages from the file again. The watched folder lost its own options, including "keep the source". The controls a profile has just set are now written into the INI instead (mirroredValues).profileSettingsbrings the copy into line with the controls it is saved from, and the settings list is read fresh before saving unless unsaved edits are waiting.output(watchSourceKeyOfOutput). With originals kept, every restart handed the whole folder to the converter again.main.goandwails.json, release text in.github/release-notes/v2.1.2.md.Checked
GOOS=windows go vet ./...is clean, allfrontend/*_check.jspass.mirror_check.jsfail in six places against the oldindex.htmland pass now.Generated by Claude Code