Repository navigation
Release 2.1.3: no more silent waiting without an Nvidia card - #7
Merged
Merged
Conversation
Without an NVIDIA driver the converter asks "Continue on the processor?" and waits 15 seconds. The window starts one converter per file and never showed that question, so every file waited. When nvidia-smi is missing altogether the window now passes -cpu itself (encoderForRun) and says so once in the log. Any unclear answer leaves the decision to the converter. Downloads: the window's own update and the converter download compare the SHA-256 digest GitHub lists for the asset, not only its size. Files: profiles, the savings balance and the window state are written next to the target and put in place with one rename (writeFileAtomic). Writes to the INI and the phrase list are serialised (fileWriteMu), so two changes in quick succession cannot overwrite each other. Version 2.1.3 in main.go and wails.json, and the release text. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GvUq7F6HRPWfTUBjDkD1bR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Small fixes and safeguards from a read-through of the code.
-cpustraight away (encoderForRun). The converter asks "Continue on the processor?" with a 15 second timeout; the window starts one converter per file and never showed that question, so every file waited. Only whennvidia-smiis missing altogether (GPUInfo.DriverMissing) does the window choose the processor itself and say so once in the log. A query that merely failed leaves the decision to the converter.verifyDownloadedDigest): the window's own update and the converter download compare the digest GitHub lists for the asset. No digest listed means no check and no refusal.writeFileAtomic) for profiles, the savings balance and the window state.fileWriteMu) to the INI and the subtitle phrase list.main.goandwails.json, release text in.github/release-notes/v2.1.3.md.Checked
GOOS=windows go vet ./...is clean, allfrontend/*_check.jspass.Generated by Claude Code