Skip to content

Release 2.1.3: no more silent waiting without an Nvidia card - #7

Merged
burnersen merged 1 commit into
mainfrom
claude/inspiring-galileo-20rizb
Nov 15, 2026
Merged

burnersen merged 1 commit into
mainfrom
claude/inspiring-galileo-20rizb

Conversation

@burnersen

Copy link
Copy Markdown
Owner

What changes

Small fixes and safeguards from a read-through of the code.

  • No NVIDIA driver: -cpu straight away (encoderForRun). The converter asks "Continue on the processor?" with a 15 second timeout; the window starts one converter per file and never showed that question, so every file waited. Only when nvidia-smi is missing altogether (GPUInfo.DriverMissing) does the window choose the processor itself and say so once in the log. A query that merely failed leaves the decision to the converter.
  • SHA-256 check for downloads (verifyDownloadedDigest): the window's own update and the converter download compare the digest GitHub lists for the asset. No digest listed means no check and no refusal.
  • Atomic writes (writeFileAtomic) for profiles, the savings balance and the window state.
  • Serialised writes (fileWriteMu) to the INI and the subtitle phrase list.
  • Version 2.1.3 in main.go and wails.json, release text in .github/release-notes/v2.1.3.md.

Checked

  • GOOS=windows go vet ./... is clean, all frontend/*_check.js pass.
  • The new tests (digest, atomic write, encoder choice) were run extracted on Linux; the full Go suite only runs on Windows, so CI is the real check.
  • Not checked: a PC without an NVIDIA driver.

Generated by Claude Code

Without an NVIDIA driver the converter asks "Continue on the processor?"
and waits 15 seconds. The window starts one converter per file and never
showed that question, so every file waited. When nvidia-smi is missing
altogether the window now passes -cpu itself (encoderForRun) and says so
once in the log. Any unclear answer leaves the decision to the converter.

Downloads: the window's own update and the converter download compare
the SHA-256 digest GitHub lists for the asset, not only its size.

Files: profiles, the savings balance and the window state are written
next to the target and put in place with one rename (writeFileAtomic).
Writes to the INI and the phrase list are serialised (fileWriteMu), so
two changes in quick succession cannot overwrite each other.

Version 2.1.3 in main.go and wails.json, and the release text.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GvUq7F6HRPWfTUBjDkD1bR
@burnersen
burnersen merged commit 97d95f1 into main Nov 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants