Repository navigation
fix(alembic): put the project root on sys.path for the migrations - #2598
Merged
Merged
Conversation
Ten migrations import alembic_migration.extensions. In the image, the project is installed non-editable and /opt/venv/bin/alembic does not put the current directory on sys.path: `alembic current` failed with "No module named 'alembic_migration'" on the production server, and the v6.29.0 migration ran with PYTHONPATH=/var/www. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #2593, found while running the migration of v6.29.0 in production.
With
alembic.inirendered by the entrypoint (#2593), the command of the wiki connected to the database, then failed:Ten migrations import
alembic_migration.extensions. In the image, the project is installed non-editable, and/opt/venv/bin/alembicdoes not put the current directory onsys.path. Locally, the editable install hid it. The migration of v6.29.0 ran with-e PYTHONPATH=/var/www.alembic.ini.innow setsprepend_sys_path = .(the working directory of the image,/var/www), withpath_separator = osas alembic 1.20 requires alongside it.Checked:
python -I(no current directory onsys.path, as in the image) runningalembic headsfailed with the same error before, and givesa7c3e1f05b2d (head)after, with deprecation warnings as errors.🤖 Generated with Claude Code