Repository navigation
fix(open): stop telling callers to accept an unrecognized iOS alert - #3935
Merged
thymikee merged 1 commit intoOct 24, 2026
Merged
Conversation
An alert-unrecognized launch confirmation can be the app's own alert, such as the App Tracking Transparency prompt, and following the warning's `alert accept` granted it. The warning, `help open`, and commands.md now say to read the alert with `alert get` and accept only a launch confirmation. Closes callstack#3921 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
I found no code problems in 876bebf. The change only touches a warning string, help text and docs, so it looks good to merge on the code side. The Smoke Tests gate is red on the iOS phase (macOS passed), and I did not see a cause in the diff. I did not run the unit test or check:affected locally, and I did not check whether any smoke script asserts on the old warning text. Please rerun the iOS smoke job, or confirm it also fails on main, before merging. |
Contributor
Author
|
Checked the iOS smoke failure at
I can't rerun jobs from a fork. Could you rerun the iOS smoke job? 🤖 Addressed by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For
launchConfirmationReason: "alert-unrecognized",opencannot tell a translatedOpen inprompt from the app's own alert. The warning still said to answer withalert accept. When the alert was the App Tracking Transparency prompt, that granted tracking. The warning,help open, andcommands.mdnow say to read the alert withalert getand accept it only when it is the launch confirmation.url-owner-unresolvedkeeps itsalert acceptguidance.Returning the alert's title and buttons in the
openresult (option 2 in the issue) is not included; the triage comment left it as a separate maintainer decision.4 files: the warning, its existing test's pattern, the
openhelp text, andcommands.md.Closes #3921
Validation
876bebf66(basec48d27a81).pnpm check:affected --run --head 876bebf66: passed,exactCommit=true. format, lint, typecheck, layering, fallow, build, vitest-related, command-docs, docs-links and docs-prose passed; replay/device lanes skipped.🤖 Generated with Claude Code