Repository navigation
Conversation
TailBase.fit extends ldf_ by _ave_period[0] + 1 tail ages, but TailBondy.fit rebuilt ldf_.values with two tail columns, so a quarterly or monthly triangle, or an annual one with projection_period outside 12-23, failed with a reshape ValueError in nan_triangle. TailBondy now evaluates its fitted curve over every projected period and fills each tail column from it. The annual default output is unchanged. Developed with an AI assistant (Árbol, running Muse).
scks1
requested review from
genedan,
henrydingliu and
kennethshsu
as code owners
November 15, 2026 13:40
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 0.0% fully typed (0 / 1)
Patch symbol details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1624 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 99 99
Lines 6427 6428 +1
Branches 811 811
=======================================
+ Hits 6102 6103 +1
Misses 207 207
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
can we incorporate the #1304 edits on the changed lines? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
TailBondynow fills every tail column thatTailBaseadds. It evaluated its fitted curve over two tail columns, so itsldf_values andddimsdisagreed on quarterly and monthly triangles, and on annual ones withprojection_periodoutside 12–23 (#1623). It now evaluates the curve over each projected period too.test_bondy_fills_every_projected_tail_columnfitsraa,quarterlyand the summed monthlyprismatprojection_period6, 12 and 24, and checks thatldf_hasTailConstant's columns and thattail_matches the default fit.Related GitHub Issue(s)
Fixes #1623
AI/LLM Usage
This change was made with Árbol, an AI assistant running on Muse, working under my direction. It found the bug, wrote the change and the test, ran the checks below and drafted this description.
Additional Context for Reviewers
raa'sldf_,cdf_,tail_andb_are identical to main's.X.ddimstoX.developmenton two of the lines this changes, so whichever merges second needs a two-line rebase. I can rebase this onto [FEAT]deprecate date dims #1304 if you'd rather.The
chainladder/tailstests (66 passed), the other test files that useTailBondy(methods/tests/test_predict.py,tests/test_public_api.pyandworkflow/tests/test_workflow.py, 229 passed) and theplot_bondy_sensitivityandtailsnotebooks under nbmake pass with the uv.lock versions (numpy 2.3.3, pandas 2.3.3), and ruff 0.16.1 check and format are clean.Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist